Desktop App Tailwind 4#1771
Open
ItsEeleeya wants to merge 16 commits intoCapSoftware:mainfrom
Open
Conversation
Also fix accidental renames inside strings Update tailwind-scrollbar Update Kobalte Use Tailwind 3's default border color selection Remove Kobalte's tailwind plugin as it's no longer needed with Tailwind 4
Closed
Member
|
please review the pr @greptileai |
Brin PR Security ScanThis PR has findings that should be reviewed.
Analyzed by Brin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was mostly handled with Tailwind's auto upgrade utility.
It fixes one issue where the
cursor-defaultwasn't respected.Now using
antialiasedfont smoothing for better visual clarity.Updated related packages:
Removed tailwind-animate in favor of tw-animate-css due to lacking v4 support.
Greptile Summary
This PR migrates the desktop app from Tailwind CSS v3 to v4, replacing
tailwind.config.jswith CSS-native@themetokens, switching from@kobalte/tailwindcssui-*variants to standarddata-*variants, and swappingtailwindcss-animatefortw-animate-css. The auto-upgrade tool handled most of the mechanical conversion.shimmerkeyframe was only defined in the deletedapps/desktop/tailwind.config.js.animate-shimmeris still used inExportPage.tsx(lines 747, 762) with no replacement@keyframesblock inmain.cssortheme.css.data-pressed:invalid in Tailwind v3 (web app):CameraPreviewWindow.tsxwas updated to usedata-pressed:bg-gray-3/data-pressed:text-gray-12, butapps/webstill runs Tailwind v3, which requires bracket syntax (data-[pressed]:). All five toolbar buttons will silently lose their pressed-state highlight.outline-2 outline-offset-2 outline-blue-300were dropped from the base toggle control styles without afocus-visible:replacement.Confidence Score: 3/5
Not safe to merge as-is — two P1 regressions affect visible user-facing behavior.
Two P1 bugs are present: the shimmer loading animation is broken in the export page, and pressed-state toolbar button styles are silently dropped in the web app due to a Tailwind v3/v4 version mismatch. The rest of the migration looks mechanically correct.
apps/desktop/src/routes/editor/ExportPage.tsx(missing shimmer keyframe) andapps/web/app/(org)/dashboard/caps/components/web-recorder-dialog/CameraPreviewWindow.tsx(data-pressed:incompatible with Tailwind v3).Important Files Changed
animate-shimmeron loading skeleton overlays, but theshimmerkeyframe definition was removed with the deleted tailwind config — animation will be broken.ui-pressed:todata-pressed:on toolbar buttons, but the web app uses Tailwind v3 which requires bracket syntax (data-[pressed]:); pressed-state styles will be silently omitted.shimmerkeyframe is still referenced in ExportPage.tsx with no replacement definition.@tailwind base/components/utilitieswith@import "tailwindcss", migrates all color/shadow tokens to CSS custom properties in@theme, replacestailwindcss-animatewithtw-animate-css, and adds@apply antialiasedon:root.@cap/ui-solid/main.css, registers@tailwindcss/typographyandtailwind-scrollbaras@plugin, and adds a@layer baseoverride to preserve Tailwind v3's default border color.ui-*variants todata-*and simplifies spacing to Tailwind tokens; removes the focus ring outline classes from the base toggle styles.@kobalte/tailwindcssplugin from the shared web config; still uses Tailwind v3, so any remainingui-*variant usage in web code should have been updated.ui-*Kobalte variants todata-*Tailwind v4 variants and arbitrary value classes to named tokens across all shared UI primitives.@cap/ui/postcssconfig with an inline@tailwindcss/postcss+autoprefixerconfig appropriate for Tailwind v4.tailwindcss@^4.2.2, replacestailwindcss-animatewithtw-animate-css, upgradestailwind-scrollbarto^4.0.2, and removes@kobalte/tailwindcssandtailwindcssfrom peer deps.Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "format" | Re-trigger Greptile